/sci/ - Science & Math

Overly complex code, it's not clear what you're saying. You're using all the wrong structures. I would give you an F+ where + was for trying, but you'll get a plain F because of all that dead and outcommented code.

1. Use switch() instead of so many if's

2. For the love of god don't use globals in C++

3. Learn OOP

Overall: 1+/10

>>4242672
Well, I ran it and the game dynamics aren't that bad, so I'll give you a fair 3/10 for the whole thing

>>4242636
> clusterfuck of if/else's
> a lot of redundant code
> count%2==0 instead of count&1
> no objects in sight
> throwing exceptions for desired logic

>>4242685
>>4242672

I haven't learned OOP yet.

Took your other points into account.

By the way, does anyone know how I might automate a bunch or redundant code? For an example, look at the void change_it function. No need to give a long explanation--just tell me what I should learn to do that.

>>4242695
Why do you think they invented the subroutines?

>>4242695
Use arrays for posX and posX_changed, so you can query them more efficiently and cut out all the redundancy in change_it

>>4242695
You've made stupid choices about how to represent your data.

void change_it(int pos, int player)
{
bool success = pos >= 0 && pos < board_size && board[pos] == free;

if(success)
{
board[pos] = player;
success = true;
}

return success;
}

Not the prettiest but you get the idea. You're doing fine for a beginner I suppose.

>>4242715
const int X = 0;
const int O = 1;
const int free = 2;
const int board_size = 9;
int board[board_size];

>>>/g/res/22178889

Interesting seeing sci vs g

it works, so it's good

>>4242723
College dropout detected.